Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoreItems<StoreItemT> doesn't really "do" anything #111

Closed
drub0y opened this issue Feb 14, 2018 · 2 comments
Closed

StoreItems<StoreItemT> doesn't really "do" anything #111

drub0y opened this issue Feb 14, 2018 · 2 comments
Assignees

Comments

@drub0y
Copy link
Contributor

drub0y commented Feb 14, 2018

The StoreItems<StoreItemT> type is a subclass of the "vanilla", StoreItems class which is capable of storing a heterogeneous set of StoreItem instances which can be retrieved via the Get<T> method. It seems like the intention of creating StoreItems<StoreItemT> was to allow the user to control the exact subset of types that could be stored (via StoreItemT), but ultimately it doesn't provide any further implementation and thus the consumer still has to provide T to the Get<T> call each time which could, theoretically, mean I could ask for a T that is not a subset of StoreItemT anyway.

There's actually no way to express exactly what I think was being attempted here in C#/.NET. If the framework wants to provide both then two separate classes are probably the way to go:

  1. StoreItems as it exists today with T Get<T>(string name)
  2. StoreItems<TStoreItem> that doesn't subclass StoreItems and provides its own TStoreItem Get (string name) method.
@drub0y
Copy link
Contributor Author

drub0y commented Apr 9, 2018

This will be obviated by #376.

@cleemullins
Copy link
Contributor

StoreItems has been totally removed by #425

ceciliaavila pushed a commit that referenced this issue Jun 25, 2019
ShYuPe pushed a commit to ShYuPe/botbuilder-dotnet that referenced this issue Aug 25, 2020
Added python 3.5 or above requirement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants