Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of FlexObject returned by LuisEntity.Resolution should be documented or changed. #233

Closed
dupuyjs opened this issue Mar 2, 2018 · 2 comments

Comments

@dupuyjs
Copy link

dupuyjs commented Mar 2, 2018

Difficult to get access to the Resolution returned in LuisEntity. DotNet developers expect a property bag/dictionary implementation for property collections. Is there a simple way to access to the properties than the following code ?

            if (context.TopIntent != null)
            {
                foreach (LuisEntity item in context.TopIntent.Entities)
                {
                    //DATE
                    if (item.Type == "builtin.datetimeV2.date")
                    {
                        FlexObject resolution = item.Resolution;

                        var instance = JsonConvert.SerializeObject(resolution["values"][0]);
                        TimeEx time = JsonConvert.DeserializeObject<TimeEx>(instance);

                        this.State.Workitem.Date = DateTime.Parse(time.value);
                    }
                }
            }
@cleemullins
Copy link
Contributor

The LUIS Middleware that's there is about to go away. If you look at PR #228, you'll see:

  1. We're pulling forward a much more mature LUIS SDK codebase.
  2. That codebase is based around JObject and related constructs.
  3. The LUIS team (@emadelwany ) is doing that work, and will own it moving forward. That puts it on a much better forward looking path.

@cleemullins
Copy link
Contributor

FlexObject has been totally removed by #425.

ShYuPe pushed a commit to ShYuPe/botbuilder-dotnet that referenced this issue Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants