Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate botbuilder.applicationinsights to xunit #4089

Closed
Virtual-Josh opened this issue Jun 17, 2020 · 1 comment · Fixed by #4608
Closed

migrate botbuilder.applicationinsights to xunit #4089

Virtual-Josh opened this issue Jun 17, 2020 · 1 comment · Fixed by #4608
Assignees
@JuanAr
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. P2 Nice to have

Comments

@Virtual-Josh
Copy link
Contributor

#4039
@Virtual-Josh Virtual-Josh added the R10 Release 10 - August 17th, 2020 label Jun 17, 2020
@Virtual-Josh Virtual-Josh self-assigned this Jun 17, 2020
@Virtual-Josh Virtual-Josh added no parity Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. labels Jun 17, 2020
@Virtual-Josh Virtual-Josh added the blocked Current progress is blocked on something else. label Jun 25, 2020
@Virtual-Josh
Copy link
Contributor Author

https://xunit.net/docs/shared-context

@Virtual-Josh Virtual-Josh added P2 Nice to have backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. and removed R10 Release 10 - August 17th, 2020 labels Jun 30, 2020
@Virtual-Josh Virtual-Josh removed their assignment Jun 30, 2020
@Virtual-Josh Virtual-Josh removed the blocked Current progress is blocked on something else. label Jul 1, 2020
@Virtual-Josh Virtual-Josh changed the title migrate botbuilder.applicationinsights migrate botbuilder.applicationinsights to xunit Jul 30, 2020
@denscollo denscollo mentioned this issue Sep 8, 2020
Merged
mrivera-ms pushed a commit that referenced this issue Sep 11, 2020
@denscollo @sw-joelmut
[#4089] Migrate Microsoft.Bot.Builder.ApplicationInsights.Tests to xU…
5541dec 
…nit (#4608)

* Migrate ApplicationInsights Tests to xUnit

* Replace Assert.ThrowsAny to Assert.Throws

* Added nameof to pass as parameter to CreateConversation

Co-authored-by: Joel Mut <joel.mut@southworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. P2 Nice to have
Projects
None yet
Milestone
No milestone
2 participants
@JuanAr @Virtual-Josh