Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception thrown when calling GetConversationMembers #5873

Closed
LeeParrishMSFT opened this issue Sep 2, 2021 · 0 comments · Fixed by #5874
Closed

Exception thrown when calling GetConversationMembers #5873

LeeParrishMSFT opened this issue Sep 2, 2021 · 0 comments · Fixed by #5874
Assignees
Labels
Area: Runtime Adaptive Runtime bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Size: S The issue is simple and well understood, it will take a day or less to complete

Comments

@LeeParrishMSFT
Copy link
Contributor

LeeParrishMSFT commented Sep 2, 2021

Version

4.14.1

Describe the bug

GetConversationMembers in Adaptive.Runtime is throwing "GetConversationMembersAsync() only works with BotFrameworkAdapter" exception when executed.

To Reproduce

Steps to reproduce the behavior:

  1. Use GetConverationMembers in Composer Bot
  2. Run the bot
  3. See runtime error reflected as ""GetConversationMembersAsync() only works with BotFrameworkAdapter"

Expected behavior

This should return the conversation members, not throw an exception.

Additional context

This occurs due to the change of the CoreBotAdapter to now derive from CloudAdapter and not BotFrameworkAdapter, which causes the check in GetConversationMembers (in Microsoft.Bot.Builder.Dialogs.Adaptive.Actions) that the Adapter is a BotFrameworkAdapter to fail and throw an exception. This code can't rely any more on the adapter being a BotFrameworkAdapter and instead should be using the helper functions in TeamsInfo to retrieve and return this information.

This was originally reported by a customer in Issue: Error when I use GetConversationMembers In MS Teams.

@LeeParrishMSFT LeeParrishMSFT added bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Size: S The issue is simple and well understood, it will take a day or less to complete Area: Runtime Adaptive Runtime labels Sep 2, 2021
@LeeParrishMSFT LeeParrishMSFT self-assigned this Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Runtime Adaptive Runtime bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Size: S The issue is simple and well understood, it will take a day or less to complete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant