Corrected GetConversationMembers to use TeamsInfo helper class rather… #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than rely on BotFrameworkAdapter directly.
Pull Request Test Coverage Report for Build 266877
💛 - Coveralls |
johnataylor
approved these changes
Sep 2, 2021
EricDahlvang
reviewed
Sep 2, 2021
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/GetConversationMembers.cs
Outdated
Show resolved
Hide resolved
… they were before.
mrivera-ms
reviewed
Sep 2, 2021
| @@ -95,5 +93,21 @@ protected override string OnComputeId() | |||
| { | |||
| return $"{GetType().Name}[{this.Property?.ToString() ?? string.Empty}]"; | |||
| } | |||
|
|
|||
| private static async Task<IEnumerable<ChannelAccount>> GetMembersAsync(IConnectorClient connectorClient, string conversationId, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
Sure, I've pushed a change to simplify this area of the code. Thanks for the suggestion.
EricDahlvang
reviewed
Sep 3, 2021
libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/GetActivityMembers.cs
Show resolved
Hide resolved
EricDahlvang
approved these changes
Sep 3, 2021
This was referenced Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… than rely on BotFrameworkAdapter directly.
Fixes #5873
Description
Corrected GetConversationMembers in Adaptive.Runtime to use TeamsInfo helper class rather than rely on BotFrameworkAdapter functions that aren't available now that CoreBotAdapter derives from CloudAdapter and not BotFrameworkAdapter
Specific Changes
Remove check for BotFrameworkAdapter and call to it for GetConversationMembersAsync and now use TeamsInfo and call GetMembersAsync.
Testing
Tested against a Composer created bot using the updated SDK to make sure all the changes were correct.