Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion to add telemetry when sending 400 response code for invalid activity #5934

Closed
ninilang opened this issue Oct 28, 2021 · 1 comment · Fixed by #6135
Closed

Suggestion to add telemetry when sending 400 response code for invalid activity #5934

ninilang opened this issue Oct 28, 2021 · 1 comment · Fixed by #6135
Assignees
@EricDahlvang
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) feature-request A request for new functionality or an enhancement to an existing one. P1 Painful if we don't fix, won't block releasing PVA PVA requirement Size: S The issue is simple and well understood, it will take a day or less to complete
Milestone
R16

Comments

@ninilang
Copy link

Use this query to search for the most popular feature requests.

Is your feature request related to a problem? Please describe.
Currently, the SDK returns a 400 response code when the incoming activity is null or the activity type is empty. This is the piece of code being referred to. Since no trace is logged here, it's difficult to know if this piece of code actually caused the 400 result code.

Describe the solution you'd like
A trace indicating that we returned a 400 response here will make it easier while look at telemetry.

Describe alternatives you've considered
N/A

Additional context
@ninilang ninilang added feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team. labels Oct 28, 2021
@mrivera-ms mrivera-ms added Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) PVA PVA requirement and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Dec 2, 2021
@mrivera-ms
Copy link
Contributor

@ninilang, can you indicate what information you need added in the message?

@mrivera-ms mrivera-ms added this to the R16 milestone Dec 2, 2021
@mrivera-ms mrivera-ms added the Size: S The issue is simple and well understood, it will take a day or less to complete label Dec 2, 2021
@gabog gabog added the P1 Painful if we don't fix, won't block releasing label Dec 6, 2021
@gabog gabog assigned mrivera-ms and EricDahlvang and unassigned mrivera-ms Jan 19, 2022
@EricDahlvang EricDahlvang mentioned this issue Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EricDahlvang EricDahlvang

Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) feature-request A request for new functionality or an enhancement to an existing one. P1 Painful if we don't fix, won't block releasing PVA PVA requirement Size: S The issue is simple and well understood, it will take a day or less to complete
Projects
None yet
Milestone
R16
Development

Successfully merging a pull request may close this issue.

Log BadRequest in adapter microsoft/botbuilder-dotnet
4 participants
@EricDahlvang @gabog @mrivera-ms @ninilang