Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net 8 #6741

Closed
tracyboehrer opened this issue Feb 1, 2024 · 7 comments · Fixed by #6762
Closed

.Net 8 #6741

tracyboehrer opened this issue Feb 1, 2024 · 7 comments · Fixed by #6762
Assignees
@sw-joelmut
Labels
feature-request A request for new functionality or an enhancement to an existing one. P1 Painful if we don't fix, won't block releasing

Comments

@tracyboehrer
Copy link
Member

  1. Test using .Net 8
  2. Scope of changes
@tracyboehrer tracyboehrer added the feature-request A request for new functionality or an enhancement to an existing one. label Feb 1, 2024
@tracyboehrer tracyboehrer added the P1 Painful if we don't fix, won't block releasing label Feb 5, 2024
@sambathrajv
Copy link

Hi, Do you know when the projects will be upgraded to .Net 8? Any ETA?

@gioce90
Copy link

gioce90 commented Mar 5, 2024

Hi, there is any news?

@ceciliaavila
Copy link
Collaborator

Hi @sambathrajv, @gioce90. We are working on updating all projects and pipeline yamls to .NET 8. We estimate finishing with this next week.

This was referenced Mar 11, 2024
Closed
Merged
Merged
@sw-joelmut sw-joelmut mentioned this issue Mar 14, 2024
Merged
@ahmed-dstny
Copy link

Hello everyone. These issues and PR are still open.. Have the .NET 8 templates been released elsewhere @ceciliaavila ?

@tracyboehrer
Copy link
Member Author

@ahmed-dstny There are some changes pending.

@ahmed-dstny
Copy link

ahmed-dstny commented May 9, 2024 •
edited
Loading

Thanks @tracyboehrer. Do you mean the warnings about the Microsoft.Identity packages? What's the expected fix (will updating the packages fix the warnings)?

@tracyboehrer
Copy link
Member Author

@ahmed-dstny No. There was a separate PR to update Microsoft.Identity.Client to 4.60.3 to resolve those warnings. That has already been merged.

@ahmed-dstny ahmed-dstny mentioned this issue May 9, 2024
Closed
tracyboehrer pushed a commit that referenced this issue May 16, 2024
@ceciliaavila @JhontSouth
[#6741] Update projects to .Net 8 (#6760)
4519cf7 
* Update test projects to .NET8

* Update test bots to .NET8

* Update CI yamls to .NET8

* Apply feedback

* keep support for netcoreapp3.1

* fix pipeline task name

* separate target framework conditionals

* add missing task to pipeline

---------

Co-authored-by: JhontSouth <jhonatan.sandoval@southworks.com>
tracyboehrer pushed a commit that referenced this issue May 16, 2024
@sw-joelmut @JhontSouth
[#6741] Update generators templates and VSIX to .Net 8 (#6762)
b15a8bf 
* Update dotnet-templates to NET 8

* Update VSIX to NET 8

* Update comment BotBuilder version to latest

* include netcoreapp3.1 in the template options

* fix README content

---------

Co-authored-by: JhontSouth <jhonatan.sandoval@southworks.com>
@sw-joelmut sw-joelmut mentioned this issue Jul 11, 2024
Merged
tracyboehrer pushed a commit that referenced this issue Jul 16, 2024
@sw-joelmut
[#6741] Remove .Net Core 3.1 from projects (#6819)
276bb33 
* Remove netcoreapp3.1 and fix System.Text.Json issue

* Fix System.Formats.Asn1 security issue

* Fix remaining System.Text.Json issue
tracyboehrer pushed a commit that referenced this issue Sep 9, 2024
@sw-joelmut
[#6741] Remove .Net Core 3.1 from projects (#6819)
eb48570 
* Remove netcoreapp3.1 and fix System.Text.Json issue

* Fix System.Formats.Asn1 security issue

* Fix remaining System.Text.Json issue
tracyboehrer added a commit that referenced this issue Sep 10, 2024
@tracyboehrer @JhontSouth @sw-joelmut
Tracyboehrer/4.22.8 patch release (#6847)
d6827f9 
* Fix for Skills endorsement check (#6846)

Co-authored-by: Tracy Boehrer <trboehre@microsoft.com>

* FederatedAppCredentials and factory

* add token credential authentication to BlobsTranscriptStore (#6813)

* [#6741] Remove .Net Core 3.1 from projects (#6819)

* Remove netcoreapp3.1 and fix System.Text.Json issue

* Fix System.Formats.Asn1 security issue

* Fix remaining System.Text.Json issue

* Removed unused argument from FederatedAuthenticator.CreateClientApplication

* Fix Microsoft.Bcl.AsyncInterfaces warning (#6837)

# Conflicts:
#	libraries/Microsoft.Bot.Builder.Azure/Microsoft.Bot.Builder.Azure.csproj

* add code ql comment about TypeNameHandling.None (#6843)

---------

Co-authored-by: Tracy Boehrer <trboehre@microsoft.com>
Co-authored-by: Jhonatan Sandoval Velasco <122501764+JhontSouth@users.noreply.github.com>
Co-authored-by: Joel Mut <62260472+sw-joelmut@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sw-joelmut sw-joelmut

Labels
feature-request A request for new functionality or an enhancement to an existing one. P1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#6741] Update generators templates and VSIX to .Net 8 microsoft/botbuilder-dotnet
6 participants
@tracyboehrer @gioce90 @ceciliaavila @sw-joelmut @sambathrajv @ahmed-dstny