Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to new CodeQL suppression syntax #6781

Closed
tracyboehrer opened this issue May 6, 2024 · 0 comments · Fixed by #6787
Closed

Convert to new CodeQL suppression syntax #6781

tracyboehrer opened this issue May 6, 2024 · 0 comments · Fixed by #6787
Assignees
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@tracyboehrer
Copy link
Member

Search for "lgtm"

An example is:

            // we use All so that we get typed roundtrip out of storage, but we don't use validation because we don't know what types are valid
            TypeNameHandling = TypeNameHandling.All, // lgtm [cs/unsafe-type-name-handling]

Replace with: //CODEQL [{id} {reason}

            TypeNameHandling = TypeNameHandling.All, // CODEQL [cs/unsafe-type-name-handling] we use All so that we get typed roundtrip out of storage, but we don't use validation because we don't know what types are valid

If you don't know the "reason" I can comment on the PR for the correct value.

@tracyboehrer tracyboehrer added feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team. labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants