Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting to new CodeQL suppression syntax #6787

Merged
merged 2 commits into from
May 8, 2024
Merged

Converting to new CodeQL suppression syntax #6787

merged 2 commits into from
May 8, 2024

Conversation

gandiddi
Copy link
Collaborator

@gandiddi gandiddi commented May 8, 2024

Fixes #6781

Description

Convert to new CodeQL suppression syntax

@gandiddi gandiddi requested a review from a team as a code owner May 8, 2024 11:22
@coveralls
Copy link
Collaborator

coveralls commented May 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 388883

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 167 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.003%) to 78.172%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Connector.Streaming/Application/TimerAwaitable.cs 1 68.25%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 93.94%
/libraries/AdaptiveExpressions/LRUCache.cs 4 87.18%
/libraries/Microsoft.Bot.Connector/Authentication/SkillValidation.cs 6 47.95%
/libraries/Microsoft.Bot.Connector/Authentication/GovernmentChannelValidation.cs 9 67.39%
/libraries/Microsoft.Bot.Connector/Authentication/EnterpriseChannelValidation.cs 10 65.22%
/libraries/Microsoft.Bot.Connector/Authentication/AseChannelValidation.cs 24 47.76%
/libraries/Microsoft.Bot.Connector/Authentication/ChannelValidation.cs 25 26.0%
/libraries/Microsoft.Bot.Connector/Authentication/EmulatorValidation.cs 31 36.11%
/libraries/Microsoft.Bot.Connector/Authentication/ParameterizedBotFrameworkAuthentication.cs 56 0.0%
Totals Coverage Status
Change from base Build 388829: -0.003%
Covered Lines: 26183
Relevant Lines: 33494
💛 - Coveralls

@gandiddi gandiddi added the Automation: No parity PR does not need to be applied to other languages. label May 8, 2024
@gandiddi gandiddi requested a review from tracyboehrer May 8, 2024 12:29
tracyboehrer
tracyboehrer reviewed May 8, 2024
View reviewed changes
libraries/Adapters/Microsoft.Bot.Builder.Adapters.Webex/WebexClientWrapper.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Connector/Authentication/AseChannelValidation.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Connector/Authentication/ChannelValidation.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Connector/Authentication/EmulatorValidation.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Connector/Authentication/EnterpriseChannelValidation.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Connector/Authentication/ParameterizedBotFrameworkAuthentication.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Connector/Authentication/ParameterizedBotFrameworkAuthentication.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Connector/Authentication/ParameterizedBotFrameworkAuthentication.cs Outdated Show resolved Hide resolved
libraries/Microsoft.Bot.Connector/Authentication/SkillValidation.cs Outdated Show resolved Hide resolved
tests/Microsoft.Bot.Connector.Tests/Authentication/JwtTokenExtractorTests.cs Outdated Show resolved Hide resolved
@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

@gandiddi gandiddi merged commit 42c4395 into main May 8, 2024
12 checks passed
@gandiddi gandiddi deleted the v-gandiddi/NewCodeQLSuppressionSyntax branch May 8, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert to new CodeQL suppression syntax
4 participants
@gandiddi @coveralls @BruceHaley @tracyboehrer