Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing QnAMaker to QnAMakerMiddleware to be consistent for #120. #123

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Changing QnAMaker to QnAMakerMiddleware to be consistent for #120. #123

merged 1 commit into from
Feb 15, 2018

Conversation

RyanDawkins
Copy link

Changing QnAMaker to QnAMakerMiddleware to be consistent for #120.

Suffixing with Middleware seems to be consistent with how Microsoft is naming other common types: https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/names-of-classes-structs-and-interfaces

Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@cleemullins cleemullins merged commit afb7a57 into microsoft:master Feb 15, 2018
ceciliaavila added a commit that referenced this pull request Jun 25, 2019
…CMSHelper

[StyleCop] Fix issues in BotkitCMSHelper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants