Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Language Support for Confirm/Choice Prompts #3129

Merged
merged 2 commits into from
Jan 9, 2020

Conversation

mdrichardson
Copy link
Contributor

@mdrichardson mdrichardson commented Dec 12, 2019

Recognizers-Text added support for a few additional languages that we don't currently support in our Confirm and Choice prompts:

  • Bulgarian
  • Hindi
  • Italian
  • Korean
  • Swedish
  • Turkish

This PR adds support for those, ensures they get test coverage, and also adds test coverage for PromptCultureModels.

Notes:

  • I skipped adding Arabic support because it is read Right to Left, which makes prompt support tricker.
  • Recognizers-Text JS SDK currently has only added Italian, but I don't believe there's a reason our C#/Node SDKs need to have matching language support
  • I'm also far from a polyglot, so most of the translations were provided by [cough]Google Translate[cough]*

Need to Decide Before Merge

English is really the only language that uses the Oxford/Serial comma. I.e, in this sentence:

Yes, no, or maybe

...the second comma is the Oxford/Serial comma. Most other languages would write it as:

Yes, no or maybe

In our SDK, this is the InlineOrMore property:

public static PromptCultureModel Spanish =>
    new PromptCultureModel
    {
        InlineOr = " o ",
        InlineOrMore = ", o ",
        Locale = Culture.Spanish,
        NoInLanguage = "No",
        Separator = ", ",
        YesInLanguage = "Sí",
    };

..without the Oxford comma, InlineOrMore would look the same as InlineOr.

The languages that I added do not have the Oxford comma (as appropriate). However, many of the current languages we have support for do use the comma in our SDK, although would likely not in real life.

  • Should those commas be removed in the SDK, or would that possibly create backwards-compat issues?

@coveralls
Copy link
Collaborator

@fuselabs
Copy link
Collaborator

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants