Additional Language Support for Confirm/Choice Prompts #3129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recognizers-Text added support for a few additional languages that we don't currently support in our Confirm and Choice prompts:
This PR adds support for those, ensures they get test coverage, and also adds test coverage for
PromptCultureModels
.Notes:
Need to Decide Before Merge
English is really the only language that uses the Oxford/Serial comma. I.e, in this sentence:
...the second comma is the Oxford/Serial comma. Most other languages would write it as:
In our SDK, this is the
InlineOrMore
property:..without the Oxford comma,
InlineOrMore
would look the same asInlineOr
.The languages that I added do not have the Oxford comma (as appropriate). However, many of the current languages we have support for do use the comma in our SDK, although would likely not in real life.