Adds support for buffered replies to skill dialog #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated SkillConversationIdFactory in DialogRootBot to use the new methods. Updated BotFrameworkHttpClient to restore RelatesTo after is done with it. Namepsaced OAuthScopeKey key in BotAdapter to avoid collisions. Updated SkillDialog to use new methods from ConversationIdFactory.
Updated MainDialog to set the property if present.
johnataylor
approved these changes
Mar 5, 2020
| if (activity.DeliveryMode == DeliveryModes.BufferedReplies && response.Body.Any()) | ||
| { | ||
| // Process replies in the response.Body. | ||
| foreach (var fromSkillActivity in response.Body) |
There was a problem hiding this comment.
nit: couple of minor things:
- technically the eoc must be the last activity in the list right? (therefore you could just check the last element of the collection)
- and you could perhaps make use of the Send (array) overload on the turnContext. for example if the collection didn't finish with the eoc you just send the lot.
anyhow not clearer that these make for clearer code - so as I say just a nit.
This was referenced Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3475