Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue #3960 [QnAMaker] [DotNet] Implementing QnAMaker's precise answering capability as an additional feature for BotFramework users #3935
Fixes issue #3960 [QnAMaker] [DotNet] Implementing QnAMaker's precise answering capability as an additional feature for BotFramework users #3935
Changes from 13 commits
a82c9fa
abf369a
f4c8c4a
96df775
9a37d25
c157ca3
b058ddd
202db55
e131a74
57a5c53
a28e2c1
c244d07
9241f3d
761ddd2
75c01c9
7bbf06a
7d27031
d1a4fb4
84233ed
55f3e2a
c556fc1
2074646
e97cd51
a5cfa1c
09c5372
a19c8d4
d0f51b5
8b7aa4a
b04b049
1e5640c
ffd0bd8
a17d450
9ce95ce
b56b246
22a3f57
e651a14
7b35226
8827223
07ee9e5
d9d42bb
be73b1e
3f57d1f
1a06a92
918f816
2152ae5
d6cf4c6
1eb0c10
7b94291
60d5fda
757ee08
cb8cfcf
11c9fa1
7b0c684
d144de8
bf2bdc1
331bfc7
27fe97b
41708f8
00e5d69
946c4b7
b98c43c
b23c293
c99e793
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class does not have a corresponding Unit Test class. I looked for AnswerSpanRequestTest.cs and cannot find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This summary is not clear. Please improve. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated as per comment.
In reply to: 433508388 [](ancestors = 433508388)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider improving the remarks text. The comment should have a link to the reponseOptions which are actually called DialogTurnResults. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Reference link.
In reply to: 430551097 [](ancestors = 430551097)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Summary "AnswerSpan". In the value here, "answerspan". Please use consistant capitalization.
Consider elaborating and adding more detail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These if statements are too complex, and they require detailed knowledge of operator precedence. Please simplify. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified by removing unnecessary, if check condition.
In reply to: 430554363 [](ancestors = 430554363)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what this means. Consider improving the quality of the doc comment. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated content.
In reply to: 430557111 [](ancestors = 430557111)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling. displayed.
Also, what are "prompts" in this case? Consider significantly improving the doc quality. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling issue fixed.
Prompts are references to possible answers, displayed along with answer in Dialog. Updated description of parameter with precise answer information.
In reply to: 430558744 [](ancestors = 430558744)