-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port AI QnA tests to Xunit #4206
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Virtual-Josh
added
no parity
R10
Release 10 - August 17th, 2020
Area: Engineering
Internal issues that are related to improving code quality, refactorings, code cleanup, etc.
labels
Jun 30, 2020
Virtual-Josh
requested review from
cleemullins,
mrivera-ms and
tomlm
as code owners
June 30, 2020 22:40
@Virtual-Josh The code here looks great. Please add in the copyright headers on the new file, and take a look at the build that's failing. Once that's resolved, we can merge. |
mrivera-ms
added
the
changes required
Reviews has requested changes to be made before approval
label
Jul 1, 2020
mrivera-ms
reviewed
Jul 14, 2020
Virtual-Josh
requested review from
carlosscastro,
chrimc62,
EricDahlvang,
gabog,
garypretty,
johnataylor and
a team
as code owners
July 15, 2020 02:03
cleemullins
added
blocked
Current progress is blocked on something else.
needs rebase
labels
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Engineering
Internal issues that are related to improving code quality, refactorings, code cleanup, etc.
blocked
Current progress is blocked on something else.
changes required
Reviews has requested changes to be made before approval
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4088