Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Transcript tests pass on a "First time run" scenario #426

Merged
merged 2 commits into from
Apr 14, 2018

Conversation

cleemullins
Copy link
Contributor

The new transcript tests would fail on initialize if the container was not there. This meant anytime they're run on a new machine, they would fail.

Switched to a DeleteIfExists, and also made the init wait for the delete to complete.

@cleemullins cleemullins added the bug Indicates an unexpected problem or an unintended behavior. label Apr 14, 2018
@cleemullins cleemullins added this to the BUILD 2018 milestone Apr 14, 2018
@cleemullins cleemullins self-assigned this Apr 14, 2018
@cleemullins cleemullins requested a review from tomlm April 14, 2018 00:11
tomlm
tomlm previously approved these changes Apr 14, 2018
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm tomlm dismissed their stale review April 14, 2018 00:28

revoking review

Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tomlm
Copy link
Contributor

tomlm commented Apr 14, 2018

    {

Add if(CheckStorageEmulator()) around this section


Refers to: tests/Microsoft.Bot.Builder.Azure.Tests/BlobTranscriptTests.cs:54 in c9a59dd. [](commit_id = c9a59dd, deletion_comment = False)

@cleemullins cleemullins merged commit 5228a66 into master Apr 14, 2018
@cleemullins cleemullins deleted the CLM/FixTranscriptTestsOnCleanRun branch June 11, 2018 21:05
ShYuPe pushed a commit to ShYuPe/botbuilder-dotnet that referenced this pull request Aug 25, 2020
ShYuPe pushed a commit to ShYuPe/botbuilder-dotnet that referenced this pull request Aug 25, 2020
* initial commit for Teams work

* initial commit for Teams

* adding teams activity handler, team info, and teams channel account classes

* adding conversation update scenario

* fixing linting issues

* updating classes to use standard attrs

* cleaning up PR feedback

* adding line

* adding another blank line

* adding mentions bot and fixing bug for resource response IDs

* Threading helper workaround

* Corrected case of "teams" folder name in core.  Corrected __init__.py in schema so TeamsChannelAccount was defined.

* adding mention bot

updating mention bot

cleaning up linter

removing readme, removing self from on_error

* resolving merge conflict

* adding mention bot

cleaning up linter

* updating linting

* adding mention bot

updating mention bot

cleaning up linter

removing readme, removing self from on_error

* resolving merge conflict

* adding mention bot

cleaning up linter

* updating linting

* Added 43.complex-dialog

* Pinned dependencies in all libraries

* adding activity update and delete

* adding list for activities

* cleaning up config

* Pinned dependencies in libraries (missed some setup.py)

* modify echo to work out of the box w/ ARM template

* Added 47.inspection (microsoft#381)

* Added 47.inspection, corrected README in 45.state-management

* Changed the on_error function to be unbound for consistency.

* ChoiceFactory.for_channel was erroneously returning a List instead of an Activity (microsoft#383)

* Refactored to unbound on_error methods when accessing outer app.py va… (microsoft#385)

* Refactored to unbound on_error methods when accessing outer app.py variables.

* Removed unused imports

* Added 16.proactive-messages (microsoft#413)

* Added 19.custom-dialogs (microsoft#411)

* Fix ChoicePrompt ListStyle.none when set via PromptOptions (microsoft#373)

* fix ChoicePrompt none style when set via options

* black compat

* Added 18.bot-authentication (microsoft#419)

* Added 17.multilingual-bot

* Added 23.facebook-events sample

* 23.facebook-events: on_error is now an unbound function

* Partial 15.handling-attachments

* Removing unnecesary encoding

* Added 15.handling-attachments

* 17.multilingual-bot suggested corrections

* 15.handling-attachments suggested corrections

* pylint and black, suggested corrections.

* pylint and black changes.  No logic changes. (microsoft#427)

* Fixes microsoft#425: Using incorrect BotState (microsoft#426)

* Added send_activities and updated the logic

* pylint: Added send_activities and updated the logic

* pylint: Added send_activities and updated the logic

* black formatter: Added send_activities and updated the logic

* Added 11.qnamaker (microsoft#429)

* Added 40.timex resolution (microsoft#430)

* Unfinished push until recognizers-text is updated.

* Added 40.timex-resolution

* Added 42.scaleout (microsoft#435)

* Pinned pytest version (microsoft#438)

* updating linting

* fixing linting

* initial commit for Teams work

* initial commit for Teams

* adding teams activity handler, team info, and teams channel account classes

* adding conversation update scenario

* fixing linting issues

* updating classes to use standard attrs

* cleaning up PR feedback

* adding line

* adding another blank line

* Corrected case of "teams" folder name in core.  Corrected __init__.py in schema so TeamsChannelAccount was defined.

* removing extension file

* resovling conflict

* more merge conflict resolution

* fixing linting

* fixing conflicts

* adding updated teams activity handler

* updating None check

* updating activity handler and fixing spacing issue

* updating activity handler and tests

* updating teams activity handler

* removing constant

* adding tests and removing constant

* moving scenarios to root

* updating attr check, using .seralize(), removing return

* rerunnign black

* updating names

* updating loop to downcast

* member not memeber

* adding s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants