Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FxCop and Async analyzers to the LUIS project. #4272

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Added FxCop and Async analyzers to the LUIS project. #4272

merged 2 commits into from
Jul 15, 2020

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Jul 15, 2020

Relates to #2367

  • Added FxCop and Async analyzers to the LUIS project.
  • I suppressed some Dispose warnings for now, we will address those once we start using HttpClientFactory in a future release.
  • Deprecated the DefaultHttpClient static property in LuisRecognizeer and crated an internal HttpClient instance property that can be seen for testing (that's the only reason why is there).
  • Added AssemblyInfo to make internal methods visible to tests.
  • Added exclude for rule CA1822 (Mark members as static) as requested by Tom.

@gabog
Added FxCop and Async analyzers to the LUIS project.
4cb691c 
I suppressed some Dispose warnings for now, we will address those once we start using HttpClientFactory in a future release.
Deprecated the DefaultHttpClient static property in LuisRecognizeer and crated an internal HttpClient instance property that can be seen for testing (that's the only reason why is there).
Added AssemblyInfo to make internal methods visible to tests.
Added exclude for rule CA1822 (Mark members as static) as requested by Tom.
@gabog gabog requested review from a team as code owners July 15, 2020 16:19
chrimc62
chrimc62 approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gabog
Update BotBuilder-DotNet.ruleset
b39c5e6 
Touched file to see if it triggers a build
@cleemullins cleemullins merged commit 12bdf98 into master Jul 15, 2020
@cleemullins cleemullins deleted the gabog/FxCopForLuis branch July 15, 2020 19:05
This was referenced Jul 15, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrimc62 chrimc62 chrimc62 approved these changes

@cleemullins cleemullins cleemullins approved these changes

@axelsrz axelsrz Awaiting requested review from axelsrz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabog @cleemullins @chrimc62