Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds FxCop to Adaptive.Testing #4300

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Adds FxCop to Adaptive.Testing #4300

merged 1 commit into from
Jul 21, 2020

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Jul 21, 2020

Relates to #2367

  • Added CultureInfo and StringComparison parameters to some string operations.
  • Removed unused fields from TestScript
  • Removed several setters from List properties that wheren't set to address CA2227 (Collection properties should be read only).
  • Renamed ContentTypes enum in HttpResponseMock to ResponseContentType in order to address CA1717 (Only FlagsAttribute enums should have plural names) and updated usages (had to use ResponseContentType because ContentType was causing collisions with the property name in that class).

@gabog
Added CulturInfo and StringComparison parameters to some string opera…
6f0a9f7 
…tions.

Removed unused fields from TestScript
Removed several setters from List properties that wheren't set to address CA2227 (Collection properties should be read only).
Renamed ContentTypes enum in HttpResponseMock to ResponseContentType in order to address CA1717 (Only FlagsAttribute enums should have plural names) and updated usages (had to use ResponseContentType because ContentType was causing collisions with the property name in that class).
@gabog gabog requested a review from a team as a code owner July 21, 2020 04:15
@gabog gabog requested review from Stevenic and axelsrz July 21, 2020 04:15
@gabog gabog merged commit d5763bd into master Jul 21, 2020
@gabog gabog deleted the gabog/AddFxCopToAdaptiveTesting branch July 21, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosscastro carlosscastro carlosscastro approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@axelsrz axelsrz Awaiting requested review from axelsrz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabog @carlosscastro