Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Directory.Build.props to the libraries folder and moved referen… #4414

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

gabog
Copy link
Contributor

@gabog gabog commented Aug 7, 2020

Fixes #2367

  • Added Directory.Build.props to the libraries folder and moved references for AsyncUsageAnalyzers, FxCop and SourceLink there.
  • This props file also enfoces warnings as errors.
  • Left a bunch of excludes in the Streaming project, we can remove that once we merge the outstanting PR.

…ces for AsyncUsageAnalyzers, FxCop and SourceLink there.

This props file also enfoces warnings as errors.
Left a bunch of excludes in the Streaming project, we can remove that once we merge the outstanting PR.
@gabog gabog added the no parity label Aug 7, 2020
@cleemullins cleemullins merged commit 897b96c into master Aug 7, 2020
@cleemullins cleemullins deleted the gabog/CherryOnTopForFxCop branch August 7, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants