Fix Random thread safety and control random seed to improve testability

[Danieladu]

Fixes #4361

Description

This PR aims to accept a "Microsoft.SetTestOptions" event, and apply the options to SDK.

Specific Changes

1. Add setTestOptions event
2. Save TestOptions into the conversation state. Including the Random seed and random value.
3. Achieve the state from "dialogContext.State", and apply it to SDK code.
4. Adjust random generator code to use the random in "TestOptions".

How to test

1. Start project "Microsoft.Bot.Builder.TestBot.Json"
2. Input 26 to see the dialog output.

Progress

• Adaptive-expression
• LG Evaluator/Expander
• Random selector

[chrimc62]

Good progress. A few things:

1. Specifying a single random with a seed is useful, but even more useful is if you can specify the single number to return every place you want a random number. The reason is that it makes for a much more stable test that is not dependent on how many times you call random. Both should be in your options.
2. To set the test options you should be using a custom setTestOptions event using an emitEvent action where eventName = "setTestOptions" and eventValue={ randomSeed: , randomValue: }. This is the event that middle ware should pick up and make available ideally through conversation.testOptions memory. This is a general mechanism where over time we can add more information to the object and either bake in uses like here or even have templates output extra information if you want to do custom testing stuff. #Resolved

[chrimc62]

Good changes for the RandomValue except for min/max adjustment.
Ideally we should not be changing adaptive at all. The event is a custom one with an arbitrary payload. The only place the event should be consumed is in middle ware that is a part of adaptive.testing. The middle ware should detect the event and put the eventValue into conversation.testOptions.

---

In reply to: 672109749 [](ancestors = 672109749)

[chrimc62]

🕐

[Danieladu]

Good changes for the RandomValue except for min/max adjustment.
Ideally we should not be changing adaptive at all. The event is a custom one with an arbitrary payload. The only place the event should be consumed is in middle ware that is a part of adaptive.testing. The middle ware should detect the event and put the eventValue into conversation.testOptions.

In reply to: 672109749 [](ancestors = 672109749)

Currently, the only thing that is blocked on my side is how to catch the "emitEvent" event in middleware.
I have made some investigations about the "emitEvent" action, and does not find any real event was emitted, so, in this way, I can not add a subscriber in a middleware. May you provide some suggestions about this one? Thanks very much.

#Resolved

[chrimc62]