Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6265] NullReferenceException when passing dialog name as variable to Microsoft.BeginDialog #6338

Merged
merged 3 commits into from
Jun 9, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #6265
#minor

Description

This PR adds the ability for the Dialog to be loaded automatically from an expression property when isn't registered manually.
Once the dialog is loaded into the dialogs stack, the next time the dialog is required, it will be already available.

Specific Changes

  • Adds a step to gather the dialog resource when isn't found in the dialogs stack from the ResourceExplorer to be loaded automatically into the dialogs stack.
  • Adds a new unit test that corroborates the dialog is being loaded correctly from an expression property.

Testing

The following image shows the dialog working from a Composer bot and the new unit test passing.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner May 20, 2022 18:19
@sw-joelmut sw-joelmut added the Automation: No parity PR does not need to be applied to other languages. label May 20, 2022
@coveralls
Copy link
Collaborator

coveralls commented May 20, 2022

Pull Request Test Coverage Report for Build 307917

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 78.969%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/BaseInvokeDialog.cs 1 93.33%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Recognizers/CrossTrainedRecognizerSet.cs 1 95.77%
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 3 89.62%
/libraries/Microsoft.Bot.Builder.Dialogs/Recognizer.cs 12 66.67%
Totals Coverage Status
Change from base Build 304888: 0.02%
Covered Lines: 25391
Relevant Lines: 32153

💛 - Coveralls

@gabog
Copy link
Contributor

gabog commented Jun 8, 2022

Hi @EricDahlvang, can you take a look at this PR? It looks good to me but would like to get a second opinion.

Thanks

Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sw-joelmut !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullReferenceException when passing dialog name as variable to Microsoft.BeginDialog
4 participants