Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch HttpRequestException in HttpRequest #6404

Merged
merged 5 commits into from
Jul 11, 2022
Merged

Catch HttpRequestException in HttpRequest #6404

merged 5 commits into from
Jul 11, 2022

Conversation

EricDahlvang
Copy link
Member

Fixes #6403

@EricDahlvang EricDahlvang added the Automation: Parity all The PR needs to be ported to all repos (dotnet, JS, Python and Java) label Jul 6, 2022
@EricDahlvang EricDahlvang requested a review from a team as a code owner July 6, 2022 21:31
@coveralls
Copy link
Collaborator

coveralls commented Jul 6, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 311852

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 79.054%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/HttpRequest.cs 1 86.82%
Totals Coverage Status
Change from base Build 311846: 0.02%
Covered Lines: 25548
Relevant Lines: 32317
💛 - Coveralls

@EricDahlvang EricDahlvang force-pushed the eric/httpRequestException branch from a0f8dbb to 1d69196 Compare July 11, 2022 18:58
@EricDahlvang EricDahlvang merged commit 9b13224 into main Jul 11, 2022
@EricDahlvang EricDahlvang deleted the eric/httpRequestException branch July 11, 2022 19:45
This was referenced Jul 11, 2022
Closed
Closed
Closed
@ceciliaavila ceciliaavila mentioned this pull request Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnataylor johnataylor johnataylor approved these changes

Assignees
No one assigned
Labels
Automation: Parity all The PR needs to be ported to all repos (dotnet, JS, Python and Java)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HttpRequest should not throw http exceptions
3 participants
@EricDahlvang @coveralls @johnataylor