Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USER scope variable values do not transfer to skill when SSO is configured #6612

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

ceciliaavila
Copy link
Collaborator

#minor

Description

This PR updates the SetProperty and SetProperties actions to save the state after setting the properties to avoid user scope properties losing their value.

Related Composer issue #9533

Specific Changes

Testing

These images show the User scope variable keeping its value after performing a token exchange operation.
image

@ceciliaavila ceciliaavila added the Automation: Parity with js The PR needs to be ported to JS label Apr 3, 2023
@ceciliaavila ceciliaavila requested a review from a team as a code owner April 3, 2023 13:39
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 346534

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.008%) to 79.097%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/Microsoft.Bot.Streaming/Payloads/StreamManager.cs 1 90.0%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/SetProperties.cs 5 68.75%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/SetProperty.cs 6 62.5%
Totals Coverage Status
Change from base Build 344537: -0.008%
Covered Lines: 25814
Relevant Lines: 32636

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: Parity with js The PR needs to be ported to JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants