Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5577] BotFrameworkClientImpl.PostActivityAsync() doesn't support null fromBotId and toBotId values #6626

Merged

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #5577

Description

This PR updates the PostActivityAsync method in BotFrameworkClientImpl to allow using null values for fromBotId and toBotId arguments. This will avoid failures when anonymous skill bots don't have the AppId property in their settings.

Specific Changes

  • Replaced the throw errors by the assignation of an empty string as the default value in the method PostActivityAsync in BotFrameworkClientImpl.

Testing

The following images show Composer and SDK bots working with anonymous skills.
image

@ceciliaavila ceciliaavila added the Automation: No parity PR does not need to be applied to other languages. label Apr 28, 2023
@ceciliaavila ceciliaavila requested a review from a team as a code owner April 28, 2023 16:51
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 350780

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.0001%) to 79.093%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/Microsoft.Bot.Streaming/Transport/WebSocket/WebSocketClient.cs 2 78.87%
Totals Coverage Status
Change from base Build 349053: 0.0001%
Covered Lines: 25831
Relevant Lines: 32659

💛 - Coveralls

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll

@tracyboehrer tracyboehrer merged commit c09099a into main May 11, 2023
@tracyboehrer tracyboehrer deleted the southworks/fix/support-null-fromBotId-and-toBotId-values branch May 11, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BotFrameworkClientImpl.PostActivityAsync() doesn't support null fromBotId and toBotId values
5 participants