Use LRUCache in ExpressionParser for efficient memory usage #6667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracyboehrer
added
the
Automation: No parity
tracyboehrer
pushed a commit
that referenced
this pull request
Jul 13, 2023
tracyboehrer
added a commit
that referenced
this pull request
Jul 13, 2023
* Upgrade Antlr4.Runtime to v.4.11.1 (#6670) * Add WithAuthority to MSAL application level (#6671) * Use LRUCache in ExpressionParser for efficient memory usage (#6667) * Microsoft.Rest.ClientRuntime bump (#6662) Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> * Updated NuGet.Packaging (#6652) Co-authored-by: PVAShiproom <pvashiproom@microsoft.com> --------- Co-authored-by: Cecilia Avila <44245136+ceciliaavila@users.noreply.github.com> Co-authored-by: Joel Mut <62260472+sw-joelmut@users.noreply.github.com> Co-authored-by: Ram Fattah <38049078+ramfattah@users.noreply.github.com> Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> Co-authored-by: PVAShiproom <pvashiproom@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6656
Description
This PR addresses a memory leak issue in the
ExpressionParserclass. Previously, theExpressionParserclass used aConcurrentDictionaryto cache parsed expressions, which could lead to excessive memory usage over time. This PR changes theExpressionParserclass to use anLRUCacheinstead, which has a maximum capacity and uses a least-recently-used policy to evict entries from the cache when the maximum capacity is reached. This change should help to mitigate the memory leak issue.Specific Changes
ExpressionParserclass to use anLRUCacheinstead of aConcurrentDictionaryfor caching parsed expressions.Testing
This change was tested using a console application that demonstrates the memory leak issue in
ExpressionParser:https://github.com/jamesemann/expression-parser-leak
Before:
After:
