#6673 - Fix of SNI auth not working in Cert based authentication #6676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion After upgrade from ADAL to MSAL auth library, sendX5C flag was not set and it breaks SN+I authentication with AAD app registrations.
starosta33
approved these changes
Jul 28, 2023
| @@ -151,11 +151,11 @@ protected override Lazy<IAuthenticator> BuildIAuthenticator() | |||
| LazyThreadSafetyMode.ExecutionAndPublication); | |||
| } | |||
|
|
|||
| private Identity.Client.IConfidentialClientApplication CreateClientApplication(X509Certificate2 clientCertificate, string appId, HttpClient customHttpClient = null) | |||
| private Identity.Client.IConfidentialClientApplication CreateClientApplication(X509Certificate2 clientCertificate, string appId, bool sendX5c, HttpClient customHttpClient = null) | |||
There was a problem hiding this comment.
should we add default value (I assume false) not to make it a breaking change?
There was a problem hiding this comment.
It's just a private method used only once in this class so we are fine like this.
tracyboehrer
added
the
Automation: No parity
ceciliaavila
approved these changes
Jul 28, 2023
tracyboehrer
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6673
Description
After upgrade from ADAL to MSAL auth library, sendX5C flag was not set and it breaks SN+I authentication with AAD app registrations.
Specific Changes
Added sendX5C flag to ConfidentialClientApplicationBuilder.WithCertificate() method.
Testing
Tested locally and also on our repo by implementing this fix on an inherited class.