Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6651] Replace TestFramework package to remove ADAL dependencies #6690

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #6651

Description

This PR replaces the use of Microsoft.Rest.ClientRuntime.Azure.TestFramework to avoid ADAL dependencies.

Specific Changes

  • Added MockContext class in Microsoft.Bot.Connector.Tests to be used by the BaseTest class.
  • Added Microsoft.Azure.Test.HttpRecorder package to use it in the MockContext class.
  • Added ResourceGroupCleaner class in Microsoft.Bot.Connector.Tests.

Testing

The following image shows the Microsoft.Bot.Connector tests passing after the changes.
image

@ceciliaavila ceciliaavila added the Automation: No parity PR does not need to be applied to other languages. label Sep 18, 2023
@ceciliaavila ceciliaavila requested a review from a team as a code owner September 18, 2023 14:20
@tracyboehrer tracyboehrer merged commit 946f9d4 into main Sep 18, 2023
13 of 14 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/remove-testframework-package branch September 18, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify no ADAL dependencies
3 participants