Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Include HEAD method to http requests #6713

Merged
merged 1 commit into from
Dec 14, 2023
Merged

feat: Include HEAD method to http requests #6713

merged 1 commit into from
Dec 14, 2023

Conversation

JhontSouth
Copy link
Collaborator

#minor

Description

This PR adds the HEAD method in the HttpRequest class and adds the method in every schema

Specific Changes

  • Added HEAD method to the HttpRequest method list.
  • Added HEAD method to schemas of testing and HttpRequest.

Testing

The following image shows the dialogs unit tests passing after the changes.
image

@JhontSouth JhontSouth added the Automation: No parity PR does not need to be applied to other languages. label Dec 12, 2023
@JhontSouth JhontSouth requested a review from a team as a code owner December 12, 2023 16:50
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 380839

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.009%) to 78.458%
Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/integration/Microsoft.Bot.Builder.Integration.AspNet.Core/ServiceCollectionExtensions.cs 1 93.55%
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/HttpRequest.cs 6 87.93%
Totals Coverage Status
Change from base Build 380329: 0.009%
Covered Lines: 26135
Relevant Lines: 33311
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 7795856 into main Dec 14, 2023
13 of 14 checks passed
@tracyboehrer tracyboehrer deleted the southworks/add/httprequest-head-method branch December 14, 2023 14:50
tracyboehrer pushed a commit that referenced this pull request Jan 24, 2024
@JhontSouth
include HEAD method to http requests (#6713)
02ec769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JhontSouth @coveralls @tracyboehrer