Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LU parser rules to support all comments in a file #6744

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Fix LU parser rules to support all comments in a file #6744

merged 3 commits into from
Feb 6, 2024

Conversation

sw-joelmut
Copy link
Collaborator

#minor

Description

This PR updated the LU lexer and parser rules to support the case with a LU file with only comments in it.

Specific Changes

  • Updated LUFileParser.g4 and LuFileLexer.g4 files.
  • Autogenerated the ANTLR files after updating the rules.
  • Updated expected results in unit tests to match the changes.
  • Added a new unit test to cover the new scenario.

Testing

This image shows the unit tests passing after the changes.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner February 6, 2024 13:14
@sw-joelmut sw-joelmut added the Automation: No parity PR does not need to be applied to other languages. label Feb 6, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 384362

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 78.379%
Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 93.94%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 93.94%
Totals Coverage Status
Change from base Build 384324: 0.0%
Covered Lines: 26174
Relevant Lines: 33394
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 84df086 into main Feb 6, 2024
9 of 11 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/antlr-parser-issue branch February 6, 2024 14:58
tracyboehrer pushed a commit that referenced this pull request Feb 6, 2024
@sw-joelmut @ceciliaavila
Fix LU parser rules to support all comments in a file (#6744)
9f1eb6e 
* Update LU parser rules to support only comments

* Fix unit tests

* Add unit test to cover all comments case

---------

Co-authored-by: CeciliaAvila <cecilia.avila@southworks.com>
tracyboehrer pushed a commit that referenced this pull request Feb 6, 2024
Revert "Fix LU parser rules to support all comments in a file (#6744)"
d46f6f3 
This reverts commit 9f1eb6e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sw-joelmut @coveralls @tracyboehrer @ceciliaavila