fix: [#6752] The ShowTypingMiddleware throws System.ObjectDisposedException when an exception occurs in the bot #6772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JhontSouth
added
the
Automation: No parity
Pull Request Test Coverage Report for Build 387573Details
💛 - Coveralls |
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll |
tracyboehrer
approved these changes
Apr 10, 2024
tracyboehrer
pushed a commit
that referenced
this pull request
Apr 15, 2024
…eption when an exception occurs in the bot (#6772) * avoid faulted task to dispose * remove nested if * remove blank spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Fixes # 6752
Description
This PR fixes the Dispose error avoiding the dispose of faulted tasks.
Specific Changes
Testing
The following image shows the bot responding correctly to other requests after an error has occurred.
