fix: Add Audience for Certificate auth to work with Skills #6794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR adds Audience to CertificateAppCredentials, so it is passed correctly when calling a Skill bot. Additionally, these changes take into consideration the PR #6694, so the improvement isn't lost in the process.
Specific Changes
oAuthScope
parameter tolibraries/Microsoft.Bot.Connector/Authentication/CertificateAppCredentials.cs
.libraries/Microsoft.Bot.Connector/Authentication/CertificateServiceClientCredentialsFactory.cs
by reverting the changes made in the PR Support SN+I authentication with AAD #6694, but maintaining the improvement.CertificateAppCredentials
per Audience, instead of having just one with the defaultapi.botframework
.Testing
The following images show the new unit test passing and the Root + Skill bots working as expected.