feat: [#6865] Provide two new invoke handlers, (message/fetchTask, message/submitAction) for Custom Feedback Loops #6871
Conversation
|
@jk-msft, @sw-joelmut , Can some text be included in the TeamsActivityHandler OnTeamsMessageFetchTaskAsync and OnTeamsMessageSubmitActionAsync response are? |
Thanks for the feedback, we added the "returns" documentation and improved the summary for the FetchTask, adding code examples for Adaptive Cards and website URL (extracted from the issue information) so the customer knows what should be returned. The SubmitAction didn't require any update, since it doesn't require any value to be returned by a customer (it returns void). |
|
Hi @tracyboehrer, this PR and a few others are failing with an error related to the private nuget feed. Let us know if there's anything we can do to help getting these merged. |
| @@ -994,6 +1001,69 @@ protected virtual Task OnTeamsMessageSoftDeleteAsync(ITurnContext<IMessageDelete | |||
| return Task.CompletedTask; | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Invoked when a feedback loop activity is received. | |||
There was a problem hiding this comment.
It would be more accurate to say "Invoked when a user submits a default or custom feedback loop form".
| /// <returns>A task that represents the work queued to execute.</returns> | ||
| protected virtual Task OnTeamsMessageSubmitActionAsync(ITurnContext<IInvokeActivity> turnContext, FeedbackResponse feedback, CancellationToken cancellationToken) | ||
| { | ||
| throw new InvokeResponseException(HttpStatusCode.NotImplemented); |
There was a problem hiding this comment.
Is it expected to throw an error here?
Fixes #6865
Description
This PR introduces two new Teams handlers, submitAction and fetchTask, alongside with the respective feedback loop classes.
Specific Changes
Testing
The following image shows a teams sample working with the new submitAction handler, fetchTask couldn't be tested since it is only available in ring0.
