fix: [#4288] CustomQuestionAnswering answers return empty metadata (#…

…4311)

* Fix bad formatting of metadata object

* Add unit test for metadata

libraries/botbuilder-ai/src/qnamaker-utils/languageServiceUtils.ts

@@ -176,7 +176,7 @@ export class LanguageServiceUtils {
                 answer: kbAnswer.answer,
                 score: kbAnswer.confidenceScore,
                 metadata: kbAnswer.metadata
-                    ? Array.from(kbAnswer.metadata)?.map((nv) => {
+                    ? Object.entries(kbAnswer.metadata).map((nv) => {
                           return { name: nv[0], value: nv[1] };
                       })
                     : null,

libraries/botbuilder-ai/tests/TestData/LanguageService/returns_answer_with_metadata.json

@@ -0,0 +1,16 @@
+{
+    "answers": [
+      {
+        "confidenceScore": 0.4854820341616869,
+        "Id": 20,
+        "answer": "They're frolicking merrily in the verdant garden!",
+        "source": "Custom Editorial",
+        "questions": [
+          "where are the unicorns?"
+        ],
+        "metadata": {
+            "title": "mythical unicorns"
+        }
+      }
+    ]
+  }

libraries/botbuilder-ai/tests/languageService.test.js

@@ -221,6 +221,7 @@ describe('LanguageService', function () {
             const results = await qna.getAnswers(context, options);
             assert.strictEqual(results.length, 1);
         });
+
         it('returns answer without any options specified', async function () {
             const qna = new CustomQuestionAnswering(endpoint);
             const context = new TestContext({ text: 'where are the unicorns?' });
@@ -230,6 +231,18 @@ describe('LanguageService', function () {
             assert.strictEqual(results.length, 1);
         });
 
+        it('returns answer with metadata', async function () {
+            const qna = new CustomQuestionAnswering(endpoint);
+            const context = new TestContext({ text: 'where are the unicorns?' });
+
+            const results = await qna.getAnswers(context);
+
+            assert.strictEqual(results.length, 1);
+            assert.strictEqual(results[0].metadata.length, 1);
+            assert.strictEqual(results[0].metadata[0].name, 'title');
+            assert.strictEqual(results[0].metadata[0].value, 'mythical unicorns');
+        });
+
         it('returns answer and active learning flag', async function () {
             const qna = new CustomQuestionAnswering(endpoint);
             const context = new TestContext({ text: 'where are the unicorns?' });