Skip to content

Commit

Permalink
fix: [#4440][Bot node.js] Compile error for accessing "conversation" …
Browse files Browse the repository at this point in the history
…and "organizer" fields for get meeting details bot API (#4442)

* Update return type in getMeetingInfo

* Update signature in botbuilder.api.md

* Update botbuilder.api.md
  • Loading branch information
ceciliaavila authored Mar 19, 2024
1 parent d7b0577 commit f487de2
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
3 changes: 2 additions & 1 deletion libraries/botbuilder/etc/botbuilder.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import { InvokeResponse } from 'botbuilder-core';
import { IReceiveRequest } from 'botframework-streaming';
import { IStreamingTransportServer } from 'botframework-streaming';
import { MeetingEndEventDetails } from 'botbuilder-core';
import { MeetingInfo } from 'botbuilder-core';
import { MeetingNotification } from 'botbuilder-core';
import { MeetingNotificationResponse } from 'botbuilder-core';
import { MeetingParticipantsEventDetails } from 'botbuilder-core';
Expand Down Expand Up @@ -481,7 +482,7 @@ export function teamsGetTenant(activity: Activity): TenantInfo | null;
export class TeamsInfo {
static cancelOperation(context: TurnContext, operationId: string): Promise<CancelOperationResponse>;
static getFailedEntries(context: TurnContext, operationId: string): Promise<BatchFailedEntriesResponse>;
static getMeetingInfo(context: TurnContext, meetingId?: string): Promise<TeamsMeetingInfo>;
static getMeetingInfo(context: TurnContext, meetingId?: string): Promise<MeetingInfo>;
static getMeetingParticipant(context: TurnContext, meetingId?: string, participantId?: string, tenantId?: string): Promise<TeamsMeetingParticipant>;
static getMember(context: TurnContext, userId: string): Promise<TeamsChannelAccount>;
// @deprecated
Expand Down
6 changes: 3 additions & 3 deletions libraries/botbuilder/src/teamsInfo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
ConversationParameters,
ConversationReference,
TeamsMeetingParticipant,
TeamsMeetingInfo,
MeetingInfo,
Channels,
MeetingNotification,
MeetingNotificationResponse,
Expand Down Expand Up @@ -101,9 +101,9 @@ export class TeamsInfo {
*
* @param context The [TurnContext](xref:botbuilder-core.TurnContext) for this turn.
* @param meetingId The BASE64-encoded id of the Teams meeting.
* @returns The [TeamsMeetingInfo](xref:botbuilder-core.TeamsMeetingInfo) fetched
* @returns The [MeetingInfo](xref:botframework-schema.MeetingInfo) fetched
*/
static async getMeetingInfo(context: TurnContext, meetingId?: string): Promise<TeamsMeetingInfo> {
static async getMeetingInfo(context: TurnContext, meetingId?: string): Promise<MeetingInfo> {
if (!context) {
throw new Error('context is required.');
}
Expand Down
4 changes: 2 additions & 2 deletions libraries/botframework-connector/src/teams/models/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { HttpResponse, ServiceClientOptions, RequestOptionsBase } from '@azure/c
import {
ConversationList,
TeamDetails,
TeamsMeetingInfo,
MeetingInfo,
MeetingNotificationResponse,
TeamsMeetingParticipant,
BatchOperationResponse,
Expand Down Expand Up @@ -112,7 +112,7 @@ export interface TeamsFetchMeetingParticipantOptionalParams extends RequestOptio
/**
* Contains response data for the fetchMeetingInfo operation.
*/
export type TeamsMeetingInfoResponse = TeamsMeetingInfo & {
export type TeamsMeetingInfoResponse = MeetingInfo & {
/**
* The underlying HTTP response.
*/
Expand Down

0 comments on commit f487de2

Please sign in to comment.