Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional Tests for Streaming Extensions Library #1188

Closed
DDEfromOR opened this issue Sep 19, 2019 · 10 comments
Closed

Functional Tests for Streaming Extensions Library #1188

DDEfromOR opened this issue Sep 19, 2019 · 10 comments
Assignees
Labels
backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. BF Agility For Issues or Feature Requests that impact the SDK Team's agility
Milestone

Comments

@DDEfromOR
Copy link
Member

There are currently no end to end functional tests for the streaming extensions library integration with Bot Builder. This means if changes to Bot Builder break compatibility with streaming extensions we won't know until it's too late.

Specific test cases that came to mind while writing this:

  • Round trip message using streaming connections. (Named Pipe w/ DL ASE, WebSocket w/ modified DL ASE or DLS)
  • Round trip message using HTTP through the streaming adapter. (New adapter with classic workflow.)
  • Round trip message with attachments using streaming connection. (Named Pipe w/ DL ASE, WebSocket w/ modified DL ASE or DLS)
@DDEfromOR DDEfromOR changed the title Add end to end functional tests. Functional Tests for Streaming Extensions Library Sep 19, 2019
@Jeffders Jeffders added 4.6 4.6 release P0 Must Fix. Release-blocker labels Sep 20, 2019
@ckkashyap
Copy link
Contributor

PR created - #1188

@cleemullins
Copy link
Contributor

#1188 is an issue, not a PR. Is there a PR that matches?

@sgellock sgellock added R7 Release 7 - December 10th, 2019 and removed 4.6 4.6 release labels Oct 23, 2019
@cleemullins
Copy link
Contributor

@DDEfromOR @ckkashyap Can I get a status update for this?

@DDEfromOR
Copy link
Member Author

Bumping this to after R7. It requires changes on the service side and then having a partner team pull those changes in to their product, which isn't likely to land before R7 due to blackouts.

@DDEfromOR DDEfromOR removed the R7 Release 7 - December 10th, 2019 label Nov 25, 2019
@gabog
Copy link
Contributor

gabog commented Jun 9, 2020

Hi @DDEfromOR, what should we do about this one? Close it? Address it in R10?

@gabog gabog added R10 Release 10 - August 17th, 2020 BF Agility For Issues or Feature Requests that impact the SDK Team's agility labels Jun 9, 2020
@DDEfromOR
Copy link
Member Author

Hi Gabo, the work to get the necessary support into the CLI to make these tests possible is finally nearing completion. We could either target R10 or close it and open a new issue once the CLI work is done. (I'm not clear on the rules here, I originally opened this just to make sure the functional tests didn't get forgotten.)

@munozemilio munozemilio added this to the R10 milestone Jul 1, 2020
@mrivera-ms
Copy link
Contributor

@mrivera-ms create a parent issue in the SDK repo.

@Zerryth
Copy link
Contributor

Zerryth commented Aug 5, 2020

End-to-End Streaming tests in botbuiler-js partially addresses this issue, specifically Daniel's 1st bullet:

Round trip message using streaming connections. (Named Pipe w/ DL ASE, WebSocket w/ modified DL ASE or DLS)

@cleemullins cleemullins added backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. and removed P0 Must Fix. Release-blocker R10 Release 10 - August 17th, 2020 labels Aug 11, 2020
@cleemullins
Copy link
Contributor

This issue is 11 months old. Removing the P0 and R10 labels, and moving to backlog.

@Zerryth
Copy link
Contributor

Zerryth commented Aug 11, 2020

Per Daniel, the E2E streaming tests implemented in R10 cover all of the concerns he had: using named pipes, websockets, and backwards compatibility with the production channel.

Closing as resolved now

@Zerryth Zerryth closed this as completed Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. BF Agility For Issues or Feature Requests that impact the SDK Team's agility
Projects
None yet
Development

No branches or pull requests

9 participants