-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional Tests for Streaming Extensions Library #1188
Comments
PR created - #1188 |
#1188 is an issue, not a PR. Is there a PR that matches? |
@DDEfromOR @ckkashyap Can I get a status update for this? |
Bumping this to after R7. It requires changes on the service side and then having a partner team pull those changes in to their product, which isn't likely to land before R7 due to blackouts. |
Hi @DDEfromOR, what should we do about this one? Close it? Address it in R10? |
Hi Gabo, the work to get the necessary support into the CLI to make these tests possible is finally nearing completion. We could either target R10 or close it and open a new issue once the CLI work is done. (I'm not clear on the rules here, I originally opened this just to make sure the functional tests didn't get forgotten.) |
@mrivera-ms create a parent issue in the SDK repo. |
End-to-End Streaming tests in botbuiler-js partially addresses this issue, specifically Daniel's 1st bullet:
|
This issue is 11 months old. Removing the P0 and R10 labels, and moving to backlog. |
Per Daniel, the E2E streaming tests implemented in R10 cover all of the concerns he had: using named pipes, websockets, and backwards compatibility with the production channel. Closing as resolved now |
There are currently no end to end functional tests for the streaming extensions library integration with Bot Builder. This means if changes to Bot Builder break compatibility with streaming extensions we won't know until it's too late.
Specific test cases that came to mind while writing this:
The text was updated successfully, but these errors were encountered: