Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Action based Messaging Extensions (fetch task) to JS #1197

Closed
Virtual-Josh opened this issue Sep 23, 2019 · 3 comments · Fixed by #1258
Closed

Port Action based Messaging Extensions (fetch task) to JS #1197

Virtual-Josh opened this issue Sep 23, 2019 · 3 comments · Fixed by #1258
Assignees
Labels
4.6 4.6 release

Comments

@Virtual-Josh
Copy link
Contributor

Copy the C# scenario to JS

https://github.com/microsoft/botbuilder-dotnet/tree/master/tests/Teams/ActionBasedMessagingExtension-FetchTask

@Virtual-Josh Virtual-Josh added 4.6 4.6 release teams labels Sep 23, 2019
@daveta daveta assigned daveta and unassigned stevengum Oct 3, 2019
@daveta
Copy link
Contributor

daveta commented Oct 3, 2019

I'm doing this in preview

@johnataylor
Copy link
Member

johnataylor commented Oct 4, 2019

This is related to a change we want to make in the SendToChannel the code should look more like this:

https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/bots/bot-conversations/bots-conv-proactive#creating-a-channel-conversation

In other words the send to channel should - depending on scenario - call CreateConversation
when you do that you are in the proactive scenario - and code such as ContinueConversation applies.

@daveta
Copy link
Contributor

daveta commented Oct 4, 2019

PR in, waiting for feedback..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.6 4.6 release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants