Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Teams] Port of ActionBasedMessagingExtension Fetch Task #1258

Merged
merged 13 commits into from
Oct 7, 2019

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Oct 4, 2019

Fixes #1197

Description

This matches current C#, if we want to change behavior of how Preview stuff works, we'll change in both..

@coveralls
Copy link

coveralls commented Oct 4, 2019

Pull Request Test Coverage Report for Build 81968

  • 4 of 15 (26.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 86.539%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/teamsTurnContextHelpers.ts 2 13 15.38%
Totals Coverage Status
Change from base Build 81965: -0.2%
Covered Lines: 4591
Relevant Lines: 5106

💛 - Coveralls

@stevengum stevengum changed the title Port of ActionBasedMessagingExtension Fetch Task [Teams] Port of ActionBasedMessagingExtension Fetch Task Oct 4, 2019
@stevengum stevengum added 4.6 4.6 release teams labels Oct 4, 2019
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes requested... And a question.

@stevengum
Copy link
Member

@daveta, can you try to incorporate the fallback scenario that we discussed with Andrew? Checking if a bot is a member of the current channel/conversation and either sending a proactive message or sending a card to the compose box?

@EricDahlvang
Copy link
Member

How does one check "if a bot is a member of the current channel/conversation"?

@stevengum
Copy link
Member

TeamsInfo.GetRoster() :)

@daveta
Copy link
Contributor Author

daveta commented Oct 5, 2019

@daveta, can you try to incorporate the fallback scenario that we discussed with Andrew? Checking if a bot is a member of the current channel/conversation and either sending a proactive message or sending a card to the compose box?

I've opened #1263 to track this. I'll take a look today.

@stevengum
Copy link
Member

To update others who may come to this thread, the getConversationMembers method does not retrieve the bot as it is an app, not a member. Previously provided information was incorrect.

@daveta daveta merged commit c217757 into master Oct 7, 2019
@daveta daveta deleted the daveta-featchtask branch October 7, 2019 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.6 4.6 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port Action based Messaging Extensions (fetch task) to JS
6 participants