-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Teams] Port of ActionBasedMessagingExtension Fetch Task #1258
Conversation
Pull Request Test Coverage Report for Build 81968
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes requested... And a question.
...es/botbuilder/tests/teams/actionBasedMessagingExtension-fetchTask/src/cardResponseHelpers.ts
Show resolved
Hide resolved
...s/teams/actionBasedMessagingExtension-fetchTask/src/actionBasedMessagingExtensionFetchBot.ts
Show resolved
Hide resolved
...s/teams/actionBasedMessagingExtension-fetchTask/src/actionBasedMessagingExtensionFetchBot.ts
Outdated
Show resolved
Hide resolved
...ies/botbuilder/tests/teams/actionBasedMessagingExtension-fetchTask/src/adaptiveCardHelper.ts
Show resolved
Hide resolved
@daveta, can you try to incorporate the fallback scenario that we discussed with Andrew? Checking if a bot is a member of the current channel/conversation and either sending a proactive message or sending a card to the compose box? |
How does one check "if a bot is a member of the current channel/conversation"? |
|
…uilder-js into daveta-featchtask
…d on and compose box
To update others who may come to this thread, the getConversationMembers method does not retrieve the bot as it is an app, not a member. Previously provided information was incorrect. |
Fixes #1197
Description
This matches current C#, if we want to change behavior of how Preview stuff works, we'll change in both..