Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Adaptive] Missing type declaration: botframework-expression #1369

Closed
boydc2014 opened this issue Oct 26, 2019 · 0 comments
Closed

[Adaptive] Missing type declaration: botframework-expression #1369

boydc2014 opened this issue Oct 26, 2019 · 0 comments
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior. P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019
Milestone

Comments

@boydc2014
Copy link
Contributor

Versions

4.future 10/25

Describe the bug

Referring botbuilder-lg from another ts project don't work out-of-box.

node_modules/botframework-expressions/lib/commonRegex.d.ts:9:27 - error TS7016: Could not find a declaration file for module 'lru-cache'. 
'C:/Users/donglei/code/testg/node_modules/lru-cache/index.js' implicitly has an 'any' type.
  Try `npm install @types/lru-cache` if it exists or add a new declaration (.d.ts) file containing `declare module 'lru-cache';`

9 import * as LRUCache from 'lru-cache';

To Reproduce

Steps to reproduce the behavior:

  1. create a new ts project
  2. refer to botbuilder-lg
  3. create an lg file and add code to evaluate it
  4. tsc

Expected behavior

no errors

Additional context

I can add @types/lru-cache to make it work, but i should not manually added another package it don't use directly.

[bug]

@boydc2014 boydc2014 self-assigned this Oct 26, 2019
@boydc2014 boydc2014 added R7 Release 7 - December 10th, 2019 adaptive bug Indicates an unexpected problem or an unintended behavior. P0 Must Fix. Release-blocker labels Oct 26, 2019
@tomlm tomlm closed this as completed Nov 26, 2019
@munozemilio munozemilio added this to the R7 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019
Projects
None yet
Development

No branches or pull requests

3 participants