Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @types/lru-cache missing in dependency #1368

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Conversation

boydc2014
Copy link
Contributor

@boydc2014 boydc2014 commented Oct 26, 2019

Fixes #1369

Description

Add lru-cache as dependency since it's been exposed in expression library.

Otherwise we will hit

node_modules/botframework-expressions/lib/commonRegex.d.ts:9:27 - error TS7016: Could not find a declaration file for module 'lru-cache'. 
'C:/Users/donglei/code/testg/node_modules/lru-cache/index.js' implicitly has an 'any' type.
  Try `npm install @types/lru-cache` if it exists or add a new declaration (.d.ts) file containing `declare module 'lru-cache';`

9 import * as LRUCache from 'lru-cache';
                            ~~~~~~~~~~~

@boydc2014 boydc2014 requested a review from Danieladu October 26, 2019 04:27
@boydc2014 boydc2014 added adaptive bug Indicates an unexpected problem or an unintended behavior. R7 Release 7 - December 10th, 2019 labels Oct 26, 2019
@boydc2014 boydc2014 self-assigned this Oct 26, 2019
@boydc2014 boydc2014 requested a review from chrimc62 October 26, 2019 04:52
@boydc2014 boydc2014 merged commit 8d015e1 into 4.future Oct 28, 2019
@boydc2014 boydc2014 deleted the donglei/fix-types branch October 28, 2019 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. R7 Release 7 - December 10th, 2019
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants