-
Notifications
You must be signed in to change notification settings - Fork 292
Closed
Labels
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.Required for internal Azure reporting. Do not delete. Do not change color.customer-replied-toIndicates that the team has replied to the issue reported by the customer. Do not delete.Indicates that the team has replied to the issue reported by the customer. Do not delete.customer-reportedIssue is created by anyone that is not a collaborator in the repository.Issue is created by anyone that is not a collaborator in the repository.
Description
Versions
What package version of the SDK are you using. 46.1
What nodejs version are you using v13.1.0
What browser version are you using N/A
What os are you using Linux
Describe the bug
botbuilder-dialogs seems to pull in the full cldr-data repo, which lands as 296MB on my computer:
> npm-why cldr-data
app > botbuilder-adapter-slack > botkit > botbuilder-dialogs > cldr-data@35.1.0
app > botkit > botbuilder-dialogs > cldr-data@35.1.0
> cd node_modules && du -hs * | sort -h
[...]
296M cldr-dataI'm not familiar with how the npm cldr-data dependency works, but botbuilder-dialogs uses a handful of files from cldr-data, why are we pulling in the entire dependency? Is my config wrong somewhere?
To Reproduce
Install botbuilder-dialog or anything that depends on it.
Expected behavior
botbuilder-dialog cherry-picks what it needs from cldr-data
Metadata
Metadata
Assignees
Labels
Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.Required for internal Azure reporting. Do not delete. Do not change color.customer-replied-toIndicates that the team has replied to the issue reported by the customer. Do not delete.Indicates that the team has replied to the issue reported by the customer. Do not delete.customer-reportedIssue is created by anyone that is not a collaborator in the repository.Issue is created by anyone that is not a collaborator in the repository.