Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] [LG] treat everything after first '=' as value for the property #1665

Closed
tomlm opened this issue Feb 5, 2020 · 0 comments · Fixed by #1737
Closed

[PORT] [LG] treat everything after first '=' as value for the property #1665

tomlm opened this issue Feb 5, 2020 · 0 comments · Fixed by #1737
Assignees
Labels
R8 Release 8 - March 16th, 2020
Milestone

Comments

@tomlm
Copy link
Contributor

tomlm commented Feb 5, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3341

close: #3339

Originally, if you want to input '=' in the structure value, an escape should be added. like:

# welcome(name)
[Activity
  text = hi, name \= @{name}
]

But now, we just treat the first equals mark as the key/value separator, so, we can write is as:

# welcome(name)
[Activity
  text = hi, name = @{name}
]

there is no need to write the backslash.

Changed projects

  • Microsoft.Bot.Builder.LanguageGeneration
  • Microsoft.Bot.Builder.LanguageGeneration.Tests
@Danieladu Danieladu self-assigned this Feb 5, 2020
@Danieladu Danieladu added lg R8 Release 8 - March 16th, 2020 labels Feb 7, 2020
@munozemilio munozemilio added this to the R8 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R8 Release 8 - March 16th, 2020
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants