Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: number input default locale #3339

Closed
wants to merge 1 commit into from
Closed

fix: number input default locale #3339

wants to merge 1 commit into from

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Feb 24, 2021

Description

NumberInput's defaultLocale property is undefined by default, added ? to avoid throwing errors.

Specific Changes

  • NumberInput

Testing

@chon219 chon219 added the Area: Adaptive The issue is related to Adaptive dialogs label Feb 24, 2021
@chon219 chon219 requested review from a team as code owners February 24, 2021 08:55
@chon219
Copy link
Member Author

chon219 commented Feb 24, 2021

closing this and waiting for @cosmicshuai 's new PR.

@chon219 chon219 closed this Feb 24, 2021
@chon219 chon219 deleted the zim/number-input-bugfix branch February 24, 2021 09:08
@coveralls
Copy link

coveralls commented Feb 24, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 595469931

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 84.814%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/input/numberInput.ts 1 83.33%
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 4 61.05%
libraries/adaptive-expressions/src/triggerTrees/node.ts 8 91.7%
Totals Coverage Status
Change from base Build 594031505: 0.2%
Covered Lines: 18578
Relevant Lines: 20883
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stevenic Stevenic Awaiting requested review from Stevenic

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
Area: Adaptive The issue is related to Adaptive dialogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chon219 @coveralls