You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After syncing with @compulim in person, we're going use the package.json's "main" and "browser" field. We'll use either es5-index.js or browser-index.js for the "browser"/ES5-transpiled code.
Versions
master
as of right now.Describe the bug
In https://github.com/microsoft/botbuilder-js/blob/master/libraries/botframework-streaming/src/index.ts, it is exporting
namedPipe.js
, which depends on Node.jsnet
package.Instead, we should have 2 entrypoints, one for Node.js and one for browser. For the browser one, it should not export
namedPipe.js
.To Reproduce
Steps to reproduce the behavior:
botframework-streaming
Expected behavior
Webpack should not throw error.
Instead, Webpack is complaining it cannot bundle
net
package. This is becausebotframework-streaming/namedPipe.js
depends onbotframework-streaming
.Additional context
Also same for Node.js, which should not include dependencies that is targeting only browsers.
[bug]
The text was updated successfully, but these errors were encountered: