Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botframework-streaming should publish ES5 code to NPM #1670

Closed
compulim opened this issue Feb 5, 2020 · 2 comments · Fixed by #1764
Closed

botframework-streaming should publish ES5 code to NPM #1670

compulim opened this issue Feb 5, 2020 · 2 comments · Fixed by #1764
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior. P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020
Milestone

Comments

@compulim
Copy link
Contributor

compulim commented Feb 5, 2020

Versions

master as of right now.

Describe the bug

botframework-streaming is not working in IE11.

Probably, it is related to tsconfig.json not emitting ES5 code.

https://github.com/microsoft/botbuilder-js/blob/master/libraries/botframework-streaming/tsconfig.json#L3

If non-ES5 is highly desirable for efficiency reason, please publish dual entrypoints to NPM, with browser pointing to ES5 code and main point to ES6+ code.

To Reproduce

Steps to reproduce the behavior:

  1. Create a web project (e.g. Webpack)
  2. Include botframework-streaming in the dependencies and the bundle
  3. Open the web project in IE11

Expected behavior

botframework-streaming should work in IE11.

Instead, it throw syntax error when loading in IE11.

Screenshots

Additional context

[bug]

@stevengum
Copy link
Member

stevengum commented Feb 6, 2020

@compulim can you confirm if the dependency chain below is correct?

botframework-streaming -> botframework-directlinejs -> botframework-webchat


Edit: Confirmed with CK that this is the dependency tree.

@stevengum stevengum self-assigned this Feb 18, 2020
@stevengum stevengum added P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020 Streaming Extensions labels Feb 18, 2020
@stevengum
Copy link
Member

#1669 (comment)

@munozemilio munozemilio added this to the R8 milestone Jul 1, 2020
@github-actions github-actions bot added the bug Indicates an unexpected problem or an unintended behavior. label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. P0 Must Fix. Release-blocker R8 Release 8 - March 16th, 2020
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants