Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] Further improve LG's performance #2441

Closed
tomlm opened this issue Jun 29, 2020 · 0 comments · Fixed by #2409
Closed

[PORT] Further improve LG's performance #2441

tomlm opened this issue Jun 29, 2020 · 0 comments · Fixed by #2409

Comments

@tomlm
Copy link
Contributor

tomlm commented Jun 29, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4083

Fixed #4156
Three operations to improve LG's performance

  1. removed
  2. Remove unnecessary visit operation to reduce the visiting time
  3. main [UpdateTemplate/AddTemplate/DeleteTemplate Method] Separately parse the template that needs to be updated, without parse the whole LG file.

Results comparison table：

LG File CRUD time before refactoring CRUD time after refactoring
file1 with 12630 lines 5000ms 120ms
file2 with 1000 lines 280ms 5ms
file3 with 100 lines 25ms 3ms

Changed projects

  • Microsoft.Bot.Builder.LanguageGeneration
  • Microsoft.Bot.Builder.LanguageGeneration.Tests

[LG,enhancement]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PORT] Further improve LG's performance microsoft/botbuilder-js
1 participant
@tomlm