Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#3917] Add ThrowOnRecursive to LG AnalyzerOptions (#5872) #4156

Merged

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #3917

Description

This PR ports the changes in BotBuilder-DotNet's PR#5872 so the analyzeTemplate method throws an error with loop detected message.

Specific Changes

  • Updated analyzer class to include the analyzerOptions in its constructor and in the analyzeTemplate method.
  • Added new analyzerOptionsclass.
  • Included the new class in the index export list.
  • Updated templates class to include the analyzerOptions in the analyzeTemplate method.
  • Added new asserts in the TestLoopDetected test.
  • Updated botbuilder-lg.api.md documentation with the changes in the API.

Testing

This image shows the TestLoopDetected passing with the new asserts.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner March 11, 2022 18:17
@coveralls
Copy link

coveralls commented Mar 11, 2022

Pull Request Test Coverage Report for Build 1970339295

  • 14 of 34 (41.18%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 84.476%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-lg/src/analyzer.ts 11 12 91.67%
libraries/botbuilder-lg/src/analyzerOptions.ts 1 20 5.0%
Totals Coverage Status
Change from base Build 1955117631: -0.3%
Covered Lines: 19681
Relevant Lines: 22067

💛 - Coveralls

@mrivera-ms mrivera-ms merged commit 0388aa2 into main Mar 17, 2022
@mrivera-ms mrivera-ms deleted the southworks/update/port-throwOnRecursive-to-analyzerOptions branch March 17, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Add ThrowOnRecursive to LG AnalyzerOptions (#5872)
3 participants