Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ThrowOnRecursive to AnalyzerOptions #5872

Merged
merged 4 commits into from
Sep 2, 2021
Merged

Add ThrowOnRecursive to AnalyzerOptions #5872

merged 4 commits into from
Sep 2, 2021

Conversation

EricDahlvang
Copy link
Member

Fixes #5814

@EricDahlvang EricDahlvang requested review from a team as code owners August 31, 2021 18:20
@coveralls
Copy link
Collaborator

coveralls commented Sep 1, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 266660

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 75.768%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.LanguageGeneration/Analyzer.cs 3 96.47%
/libraries/Microsoft.Bot.Builder.LanguageGeneration/Templates.cs 7 95.88%
Totals Coverage Status
Change from base Build 266218: -0.04%
Covered Lines: 23160
Relevant Lines: 30567
💛 - Coveralls

@mrivera-ms mrivera-ms merged commit bf9d4f1 into main Sep 2, 2021
@mrivera-ms mrivera-ms deleted the eric/cycleDetectionLGOption branch September 2, 2021 17:15
This was referenced Sep 2, 2021
Closed
Closed
Closed
@EricDahlvang EricDahlvang changed the title Add ThrowOnRecursive to LG EvaluationOptions Add ThrowOnRecursive to AnalyzerOptions Sep 2, 2021
EricDahlvang added a commit that referenced this pull request Sep 3, 2021
@EricDahlvang
Add ThrowOnRecursive to LG EvaluationOptions (#5872)
2551d3e 
* Add ThrowOnRecursive to LG EvaluationOptions

* Address ThrowOnRecursive feedback

* Do not pass LgOptions to Analyzer constructor (they are available through the Templates instance)

* Add AnalyzerOptions
EricDahlvang added a commit that referenced this pull request Sep 3, 2021
@EricDahlvang
Add ThrowOnRecursive to LG EvaluationOptions (#5872) (#5877)
efc4b46 
* Add ThrowOnRecursive to LG EvaluationOptions

* Address ThrowOnRecursive feedback

* Do not pass LgOptions to Analyzer constructor (they are available through the Templates instance)

* Add AnalyzerOptions
@ceciliaavila ceciliaavila mentioned this pull request Mar 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrivera-ms mrivera-ms mrivera-ms approved these changes

@boydc2014 boydc2014 boydc2014 approved these changes

@tomlm tomlm Awaiting requested review from tomlm

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template Analyzer does not detect loops, Template Evaluator is now responsible for loop detection
4 participants
@EricDahlvang @coveralls @boydc2014 @mrivera-ms