Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] Add missing code docs for Configuration lib #2444

Closed
tomlm opened this issue Jun 29, 2020 · 2 comments · Fixed by #2834
Closed

[PORT] Add missing code docs for Configuration lib #2444

tomlm opened this issue Jun 29, 2020 · 2 comments · Fixed by #2834
Assignees
@joshgummersall
Labels
Area: Docs Documentation issue (missing needs updates, etc.) P2 Nice to have

Comments

@tomlm
Copy link
Contributor

tomlm commented Jun 29, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4190

Towards #4052.

Adds missing code docs for configuration library.

Also removes the suppression of CS1309 as part of microsoft/botframework-sdk#5933

Changed projects

  • Microsoft.Bot.Configuration
@joshgummersall joshgummersall added Area: Docs Documentation issue (missing needs updates, etc.) P2 Nice to have labels Sep 25, 2020
@joshgummersall joshgummersall self-assigned this Sep 25, 2020
@joshgummersall
Copy link
Contributor

TODO: mark npm package as deprecated.

@joshgummersall
Copy link
Contributor

Related: #2436

joshgummersall pushed a commit that referenced this issue Oct 1, 2020
Deprecate all botframework-config exports
2b55162 
Fixes #2444
@joshgummersall joshgummersall mentioned this issue Oct 1, 2020
Merged
joshgummersall pushed a commit that referenced this issue Oct 2, 2020
Deprecate all botframework-config exports
250b780 
Fixes #2444
joshgummersall pushed a commit that referenced this issue Oct 2, 2020
Deprecate all botframework-config exports
7359d2b 
Fixes #2444
stevengum added a commit that referenced this issue Oct 4, 2020
@joshgummersall @stevengum
Deprecate all botframework-config exports (#2834)
051f4bf 
Fixes #2444

Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshgummersall joshgummersall

Labels
Area: Docs Documentation issue (missing needs updates, etc.) P2 Nice to have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate all botframework-config exports microsoft/botbuilder-js
2 participants
@joshgummersall @tomlm