Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samples E2E JS CoreBot tests are failing #4179

Closed
BruceHaley opened this issue Apr 1, 2022 · 0 comments · Fixed by #4178
Closed

Samples E2E JS CoreBot tests are failing #4179

BruceHaley opened this issue Apr 1, 2022 · 0 comments · Fixed by #4178
Assignees
@BruceHaley
Labels
bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report.

Comments

@BruceHaley
Copy link
Contributor

These E2E JS CoreBot test pipelines are failing:

  • Sample-Js-CoreBot-Linux-Test-yaml
  • Sample-Js-CoreBot-Win-Test-yaml
  • Sample-Ts-CoreBot-Linux-Test-yaml
  • Sample-Ts-CoreBot-Win-Test-yaml

They started failing after the merge of this PR: #4152

A sample error from this build:

npm ERR! path D:\a\1\s\samples\typescript_nodejs\13.core-bot
node_modules/botbuilder-ai/lib/luisAdaptivePredictionOptions.d.ts(8,79): error TS2307: Cannot find module 'adaptive-expressions' or its corresponding type declarations.

The likely cause was moving the "adaptive-expressions" reference in libraries/botbuilder-ai/package.json from dependencies to devDependencies.
@BruceHaley BruceHaley added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Apr 1, 2022
@BruceHaley BruceHaley self-assigned this Apr 1, 2022
@BruceHaley BruceHaley mentioned this issue Apr 1, 2022
Merged
@BruceHaley BruceHaley changed the title Samples E2E JS CoreBot tests failing Samples E2E JS CoreBot test pipelines failing Apr 1, 2022
@BruceHaley BruceHaley added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Apr 1, 2022
@BruceHaley BruceHaley changed the title Samples E2E JS CoreBot test pipelines failing Samples E2E JS CoreBot tests are failing Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BruceHaley BruceHaley

Labels
bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: failing Samples E2E JS CoreBot tests microsoft/botbuilder-js
1 participant
@BruceHaley