Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failing Samples E2E JS CoreBot tests #4178

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Apr 1, 2022

Fixes #4179

Description

4 E2E test pipelines are failing. A sample error:

npm ERR! path D:\a\1\s\samples\typescript_nodejs\13.core-bot
node_modules/botbuilder-ai/lib/luisAdaptivePredictionOptions.d.ts(8,79): error TS2307: Cannot find module 'adaptive-expressions' or its corresponding type declarations.

This was a regression from this PR: #4152

The fix

Move the "adaptive-expressions" reference in libraries/botbuilder-ai/package.json from devDependencies to dependencies.

Tests

Running against the packages with the fix, the 4 failing test pipelines passed:

@coveralls
Copy link

coveralls commented Apr 1, 2022

Pull Request Test Coverage Report for Build 2080108338

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.484%

Totals Coverage Status
Change from base Build 2073932673: 0.0%
Covered Lines: 19753
Relevant Lines: 22145

💛 - Coveralls

@BruceHaley BruceHaley changed the title Move "adaptive-expressions" to dependencies Fix failing Samples E2E JS CoreBot test pipelines Apr 1, 2022
@BruceHaley BruceHaley changed the title Fix failing Samples E2E JS CoreBot test pipelines fix: failing Samples E2E JS CoreBot test pipelines Apr 1, 2022
@BruceHaley BruceHaley marked this pull request as ready for review April 1, 2022 17:50
@BruceHaley BruceHaley requested a review from a team as a code owner April 1, 2022 17:50
@BruceHaley
Copy link
Contributor Author

Closed temporarily for more testing.

@BruceHaley BruceHaley closed this Apr 1, 2022
@BruceHaley BruceHaley reopened this Apr 1, 2022
@BruceHaley BruceHaley changed the title fix: failing Samples E2E JS CoreBot test pipelines fix: failing Samples E2E JS CoreBot tests Apr 2, 2022
@tracyboehrer tracyboehrer merged commit 0dcd8dd into main Apr 8, 2022
@tracyboehrer tracyboehrer deleted the bruce/corebotfix3-31 branch April 8, 2022 14:09
tracyboehrer added a commit that referenced this pull request Apr 13, 2022
Co-authored-by: BruceHaley <v-brucehaley@microsoft.com>
tracyboehrer added a commit that referenced this pull request Apr 13, 2022
Co-authored-by: BruceHaley <v-brucehaley@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Samples E2E JS CoreBot tests are failing
3 participants