Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessagingExtensionResultType missing silentAuth Type #4296

Closed
wenytang-ms opened this issue Jul 28, 2022 · 1 comment · Fixed by #4305
Closed

MessagingExtensionResultType missing silentAuth Type #4296

wenytang-ms opened this issue Jul 28, 2022 · 1 comment · Fixed by #4305
Assignees
@JuanAr @tracyboehrer
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Issue is created by anyone that is not a collaborator in the repository. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@wenytang-ms
Copy link
Contributor

wenytang-ms commented Jul 28, 2022 •
edited
Loading

Versions

What package version of the SDK are you using. v4.16.0
What nodejs version are you using: v14
What browser version are you using: 103.0.1264.71
What os are you using: windows 11

Describe the bug

BotFramework-schema define the message extension types, the MessagingExtensionResultType miss silentAuth type, TypeScript report the type error.
Ref SSO with Message Extension says that enable SSO needs to modify auth to silentAuth, or other ways to return MessagingExtensionResult ?

Screenshots

image
@wenytang-ms wenytang-ms added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jul 28, 2022
@tracyboehrer tracyboehrer added customer-reported Issue is created by anyone that is not a collaborator in the repository. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Jul 28, 2022
@tracyboehrer tracyboehrer self-assigned this Jul 28, 2022
@wenytang-ms
Copy link
Contributor Author

wenytang-ms commented Aug 1, 2022 •
edited
Loading

Is there any schedule for this fix?

@ceciliaavila ceciliaavila mentioned this issue Aug 5, 2022
Merged
@ramfattah ramfattah mentioned this issue Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

@tracyboehrer tracyboehrer

Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Issue is created by anyone that is not a collaborator in the repository. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [#4296] MessagingExtensionResultType missing silentAuth Type microsoft/botbuilder-js
3 participants
@JuanAr @tracyboehrer @wenytang-ms